Google Git
Sign in
chromium / chromium / src / 091930a04ab79f41adcab437c2bb61b9741b6042
commit091930a04ab79f41adcab437c2bb61b9741b6042[log] [tgz]
authorByungwoo Lee <blee@igalia.com>Tue Mar 04 00:39:26 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Mar 04 00:39:26 2025
tree5bfed24c92a12291139e696fa160ae37af7bb140
parentef8b763ec820354d29babc475dc560eb65c37028 [diff]
Fix build with safe_browsing_mode=0 (5/5)

Fix the `safe_browsing_mode=0` build by guarding header includes
and related codes using `BUILDFLAG(SAFE_BROWSING_AVAILABLE)`.

This CL is a part of the build fix that guards following header
inclusions under the flag:
- chrome/browser/safe_browsing/
  - download_protection/download_protection_service.h
  - safe_browsing_service.h
- components/safe_browsing/content/renderer/
  - phishing_classifier/phishing_model_setter_impl.h
  - renderer_url_loader_throttle.h
  - websocket_sb_extensions_handshake_throttle.h

guards following build dependency under `safe_browsing_mode==0`
condition:
- //components/safe_browsing/content/browser:client_side_detection_service

and remove guards for the following build targets to avoid header
inclusion error:
- //components/safe_browsing/content/common/proto:download_file_types_proto
  - download_file_types.proto

Low-Coverage-Reason: TRIVIAL_CHANGE This change contains only minor build fix.

Bug: 390205854
Change-Id: I9a56bbf5c5362096a3dea16f0b755b78e1fcf902
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6184185
Commit-Queue: Byungwoo Lee <blee@igalia.com>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427470}
13 files changed
tree: 5bfed24c92a12291139e696fa160ae37af7bb140
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.