Google Git
Sign in
chromium / chromium / src / 0955c7cf4f35e05f6f7a13afeefed7828f039b42
commit0955c7cf4f35e05f6f7a13afeefed7828f039b42[log] [tgz]
authorVictor Tan <victortan@chromium.org>Wed Jun 08 17:44:31 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 08 17:44:31 2022
treeda4e24e6ca2c7ef8c2f158cbe0d0aec6517913e6
parent92ebb421ee8e7564fc35771fcd60fb362faa6fd1 [diff]
[Merge M103] Fix potential crash on access language code vector

Replay the potential crash on browser tests when set the xml lang tag as
a value of '-'.

a dash value seems an invalid language code. The WPT split function
ignore the empty entry as default which can cause a vector be empty.

From the crash report, it's on access a vector might be empty.

0x00000000cb7b577a	(libmonochrome.so -vector.h:1032)		blink::(anonymous namespace)::GetLanguageCode(WTF::String const&)

Report url: https://crash.corp.google.com/11b7e66f5cf7851e

Bug: 1332519
Change-Id: Ieb8dd709f7509cc29dbef11b249091c4e74d4ffe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3689593
Reviewed-by: Krishna Govind <govind@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Owners-Override: Krishna Govind <govind@chromium.org>
Commit-Queue: Victor Tan <victortan@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#687}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
2 files changed
tree: da4e24e6ca2c7ef8c2f158cbe0d0aec6517913e6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.