commit 095b12299509ccaa6439f82d5df4cd17c0f4637c
author Minoru Chikamune <chikamune@chromium.org> Tue Jan 21 03:38:15 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jan 21 03:38:15 2025
tree d1a2ff3de9651226b0e73a2429e93157c3f90410
parent 934178da8774ceb81dc5baa9c3a979239399616b

Revert "Improve management of command-line passed shared memory handle."

This reverts commit f9fc4f9fc7071a2760089ebd9aaae3f473ba2076.

Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5717672433025024

Sample build with failed test: https://ci.chromium.org/b/8725182265256599073
Affected test(s):
ninja://chrome/test:browser_tests/AdHeuristicTPCDBrowserTestSkipTopLevelTrialGrant.CookieBlocked
ninja://chrome/test:browser_tests/AdHeuristicTPCDBrowserTestSkipTrialGrant.CookieBlocked
ninja://chrome/test:browser_tests/EligibilityServiceBrowserTest.EligibilityChanged_NetworkContextUpdated/All.1
ninja://chrome/test:browser_tests/RequestStorageAccessForWithFirstPartySetsBrowserTest.AllowedByStorageAccessTypeUma_kStorageAccessOnly

Original change's description:
> Improve management of command-line passed shared memory handle.
>
> This CL changes the shared memory handle switch logic to allow the
> browser process to retain its handle in order to properly dispose of it
> when the child process assumes ownership and/or terminates.
>
> On Windows, in particular, we are seeing evidence that these handles are
> being leaked and/or perhaps being inadvertently being mapped twice.
>
> Ownership of the handles is shared between the child process host and
> the child process launcher/helper, which operate asynchronously to one
> another. As such, the handles are managed as refcounted data.
>
> Note: The handles are not accessed asynchronously. Either the launcher
> (via command line) or the host (via IPC) passes the handle to the child,
> but their destruction order is non-deterministic.
>
> Bug: 351671612, 40109064, 40818143
> Change-Id: Ie4d17ad7ce0d29218f926f137dda61d94983d22a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098050
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Commit-Queue: Roger McFarlane <rogerm@chromium.org>
> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1408794}

Bug: 351671612, 40109064, 40818143
Change-Id: Ifcdf686f4db214d44c35f952e8e481acefc0819f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6174715
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Owners-Override: Minoru Chikamune <chikamune@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408841}