Google Git
Sign in
chromium / chromium / src / 096e4ab613058800b6bbc20744ac0c78ce8e11b9
commit096e4ab613058800b6bbc20744ac0c78ce8e11b9[log] [tgz]
authorShakti Sahu <shaktisahu@chromium.org>Fri Feb 07 21:31:18 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 07 21:31:18 2025
tree0388c8ad050f6be0b6146137d0090d42e877e60d
parent2b7390111f4987f8ab6781cebed91172d2b56464 [diff]
[Messaging] Removed tab doesn't make it to activity summary card

Tab removed events are special: They don't contribute to the tab
group's dirty dot, nor tab switcher dirty dot, but are required to
show on the activity summary card.
Hence, in this CL, we mark the TAB_REMOVED events as dirty (DirtyType::
kTombStoned) while storing in the DB. From the front-end, we need to
query them for tombstoned type and filter them by group ID and
collaboration event TAB_REMOVED.
This CL fixes it on Android. iOS will be fixed in the followup CL.

Bug: 395074987
Change-Id: I0e4a86ffb042ff6007abafe2a30535fbd894297b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6237066
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417559}
6 files changed
tree: 0388c8ad050f6be0b6146137d0090d42e877e60d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.