Google Git
Sign in
chromium / chromium / src / 09d8b92a7e23c0417daf7f2568ba6236148b79ae
commit09d8b92a7e23c0417daf7f2568ba6236148b79ae[log] [tgz]
authorluci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>Fri Mar 28 21:17:38 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Mar 28 21:17:38 2025
treec15259fc5f5acc4bb48414237a76ab722d3cdc40
parent7a3f80e2cc6e0a760d443e86dc79b6e38044b4f6 [diff]
Revert "Enable unsafe libc calls in Chromium's unsafe buffer paths file."

This reverts commit b5e047c7765e69ff5cd40525dc11b627f6a9f83b.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8719120644971767441

Sample failed build: https://ci.chromium.org/b/8719120644971767441

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6393815&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8719120644971767441&type=BUG

Original change's description:
> Enable unsafe libc calls in Chromium's unsafe buffer paths file.
>
> One-line change to ease revert if some untestable downstream build
> breaks with an `error: ... is unsafe` warning.
>
> Bug: 390223051
> Change-Id: I5852938e12745d8f859d207d55f679f8e56ab137
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393815
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Mega-CQ: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1439688}
>

Bug: 390223051
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I289079a905c2436b9db8385e10e14a8ed5e5d564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410571
Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1439705}
1 file changed
tree: c15259fc5f5acc4bb48414237a76ab722d3cdc40
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.