commit 09ecda4f5f97e6cba94e7885ccce7754edf69110
author Matt Mueller <mattm@chromium.org> Tue Aug 23 01:52:04 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Aug 23 01:52:04 2022
tree b7f898b32978075c5d0ae45e51d1197270d3f763
parent 91516a73a59056b24abb696ea1cae6769323f85d

Change cert viewer export button visible text and a11y label

The visible text should be the old "Export..." label, while the a11y
label should be the more descriptive "Export selected certificate"

Bug: 1354698
Change-Id: I0d0e2e9d32335f84ab005894ded44a557936140c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840884
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1038070}

chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index a696b5b..12d3276 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -3457,7 +3457,10 @@
           Certificate Signature Value
         </message>
         <message name="IDS_CERT_DETAILS_EXPORT_CERTIFICATE" desc="The label of the button to export the selected certificate">
-          E&amp;xport selected certificate...
+          E&amp;xport...
+        </message>
+        <message name="IDS_CERT_DETAILS_EXPORT_CERTIFICATE_A11Y_LABEL" desc="The accessibility label of the button to export the selected certificate. This message is spoken by screen readers when the IDS_CERT_DETAILS_EXPORT_CERTIFICATE control gets focus, but is not visually rendered.">
+          Export selected certificate
         </message>
 
         <message translateable="false" name="IDS_CERT_OID_AVA_COMMON_NAME" desc="">

chrome/app/generated_resources_grd/IDS_CERT_DETAILS_EXPORT_CERTIFICATE.png.sha1

diff --git a/chrome/app/generated_resources_grd/IDS_CERT_DETAILS_EXPORT_CERTIFICATE.png.sha1 b/chrome/app/generated_resources_grd/IDS_CERT_DETAILS_EXPORT_CERTIFICATE.png.sha1
index cc44c34..9943333 100644
--- a/chrome/app/generated_resources_grd/IDS_CERT_DETAILS_EXPORT_CERTIFICATE.png.sha1
+++ b/chrome/app/generated_resources_grd/IDS_CERT_DETAILS_EXPORT_CERTIFICATE.png.sha1
@@ -1 +1 @@
-55a7a3c61cd9fa7ff8bf31be3214cb615ac6d55d
\ No newline at end of file
+36221f612dafc5a103e606b976fdee82fe8f6f59
\ No newline at end of file

chrome/app/generated_resources_grd/IDS_CERT_DETAILS_EXPORT_CERTIFICATE_A11Y_LABEL.png.sha1

diff --git a/chrome/app/generated_resources_grd/IDS_CERT_DETAILS_EXPORT_CERTIFICATE_A11Y_LABEL.png.sha1 b/chrome/app/generated_resources_grd/IDS_CERT_DETAILS_EXPORT_CERTIFICATE_A11Y_LABEL.png.sha1
new file mode 100644
index 0000000..9943333
--- /dev/null
+++ b/chrome/app/generated_resources_grd/IDS_CERT_DETAILS_EXPORT_CERTIFICATE_A11Y_LABEL.png.sha1
@@ -0,0 +1 @@
+36221f612dafc5a103e606b976fdee82fe8f6f59
\ No newline at end of file

chrome/browser/resources/certificate_viewer/certificate_viewer.html

diff --git a/chrome/browser/resources/certificate_viewer/certificate_viewer.html b/chrome/browser/resources/certificate_viewer/certificate_viewer.html
index 1361ecc0..a0c8b8c7 100644
--- a/chrome/browser/resources/certificate_viewer/certificate_viewer.html
+++ b/chrome/browser/resources/certificate_viewer/certificate_viewer.html
@@ -107,7 +107,8 @@
                aria-readonly="true" aria-labelledby="cert-field-value-label"
                role="textbox"></div>
           <div>
-            <button id="export">$i18n{export}</button>
+            <button id="export"
+              aria-label="$i18n{exportA11yLabel}">$i18n{export}</button>
           </div>
         </div>
       </div>

chrome/browser/ui/webui/certificate_viewer_ui.cc

diff --git a/chrome/browser/ui/webui/certificate_viewer_ui.cc b/chrome/browser/ui/webui/certificate_viewer_ui.cc
index c648644a..79b49b9 100644
--- a/chrome/browser/ui/webui/certificate_viewer_ui.cc
+++ b/chrome/browser/ui/webui/certificate_viewer_ui.cc
@@ -30,6 +30,7 @@
       {"details", IDS_CERT_INFO_DETAILS_TAB_LABEL},
       {"close", IDS_CLOSE},
       {"export", IDS_CERT_DETAILS_EXPORT_CERTIFICATE},
+      {"exportA11yLabel", IDS_CERT_DETAILS_EXPORT_CERTIFICATE_A11Y_LABEL},
       {"issuedTo", IDS_CERT_INFO_SUBJECT_GROUP},
       {"issuedBy", IDS_CERT_INFO_ISSUER_GROUP},
       {"cn", IDS_CERT_INFO_COMMON_NAME_LABEL},