Revert "[PiP][Fullscreen] Add FullscreenVideoPictureInPicture feature flag for Android." This reverts commit 114015fc10299ed363125df7ceeabbafe4e044db. Reason for revert: The Suspect CL https://chromium-review.googlesource.com/q/I41bdfb0b3ebd524aaf5b920868818c820ada6115 is highly likely the cause of the crash. Please see the crash report http://crash/583804505b0352cd. Rebase the Revert CL on top of main branch with conflicts allowed option to prevent false positive merge conflicts. If you agree with the revert CL, please approve it and mark as Commit-Queue +2 to submit it. More details can be found in the go/crash-revert-cls-creation. Original change's description: > [PiP][Fullscreen] Add FullscreenVideoPictureInPicture feature flag for Android. > > This CL introduces a new feature flag `FullscreenVideoPictureInPicture` > to control the fullscreen video Picture-in-Picture behavior on Android. > The flag is used to guard the initialization and usage of > `FullscreenVideoPictureInPictureController` in `ChromeActivity`. > > Key changes: > - Defined `kFullscreenVideoPictureInPicture` in media switches. > - Exposed the flag to Java via `ChromeFeatureList`. > - Guarded `FullscreenVideoPictureInPictureController` in `ChromeActivity`. > - Added the flag to `chrome://flags`. > - Added field trial testing config and metrics enums. > - Added tests for both enabled and disabled states. > > Bug: 486262122 > Change-Id: I41bdfb0b3ebd524aaf5b920868818c820ada6115 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7609066 > Commit-Queue: Phil Yan <philyan@chromium.org> > Reviewed-by: Wenyu Fu <wenyufu@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1593419} > Crash Bug: 489715789 Change-Id: Ie5cbccacd08006fc40a6921063f0e269be5d47f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7633862 Commit-Queue: Phil Yan <philyan@chromium.org> Reviewed-by: Wenyu Fu <wenyufu@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Phil Yan <philyan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1594090}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.