commit 0a4827654a1ed001eca9e5746923366f5e049d3a
author John Delaney <johnidel@chromium.org> Wed Feb 06 16:33:21 2019
committer Commit Bot <commit-bot@chromium.org> Wed Feb 06 16:33:21 2019
tree 3b5eeb872e45dc6a3c267646b515dd5a58f16b86
parent 41e6cd787e2de92e70496d218bfe347225e918b7

Fix AdsPageLoadMetricsObserverBrowserTest.FramePixelSize flakiness

This test is flaking on bots due to incorrectly recording the size
of adframes with a display: none style. The underlying problem is that
display:none frames do not send size updates to the browser process.
As such, in this test there is a race condition between the first size
update being sent, and the display property being set on the frame.
Because we do not really care about the size of display:none frames
as they are not visible to the user, I will remove this part
of the test and replace with a TODO until the underlying issue can be
solved.

This was previously not flaking because we did not record the size
of display:none iframes.

FintIt: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjQ5NjAyODVhYzAyYmYzM2M0NjNhZjI5MmQ5ZTVhNzZkN2JlNWUzZAw

Bug: 924357
Change-Id: I12ff78c8aad14cd44767ce916e162e53636e4c6c
Reviewed-on: https://chromium-review.googlesource.com/c/1456496
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629605}