Don't add disabled menu items to selection menu We currently add menu items to a list of items regardless of whether they're enabled or not. We then do some processing across all items in that list before finally building the final menu. When building the menu, if the item isn't enabled, we don't add it. It's probably better to just not add these menu items to the list in the first place. This CL should not change menu behavior. Change-Id: Iaee56bb04baf48a5f1eb962cc0edf75592113f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7036834 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Alex Mitra <alexmitra@chromium.org> Cr-Commit-Position: refs/heads/main@{#1530744}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.