Google Git
Sign in
chromium / chromium / src / 0a778ea3c2719dc76b3331db644abb66210a785e
commit0a778ea3c2719dc76b3331db644abb66210a785e[log] [tgz]
authorMichael Lippautz <mlippautz@chromium.org>Wed Jul 14 13:31:15 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 14 13:31:15 2021
tree0d48704e3fa721779da11960514cff4b398328ea
parent90262cf840b98fa2f12fe753bbb36355897bf0d8 [diff]
EventTargetData: Avoid inlining a GarbageCollected object

Use a combination of a mixin, private inheritance, and a separate
object to allocate to avoid the GC_PLUGIN_IGNORE.

In addition, having a proper mixin interface actually allows for the
EventTargetData reference to actually escape onto the stack or heap,
which would otherwise be hard to check and enforce.

The only trade off is that this approach minmally regressed tracing
performance of EventTargetDataMap because the GC has to lookup the
header of a mixin object.

Bug: 513199, 1229149
Change-Id: I304655f4805810c38304b49526fb01b6d2eb87d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3026825
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#901470}
3 files changed
tree: 0d48704e3fa721779da11960514cff4b398328ea
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.