commit | 0ab73d8ef011bd36076a1b07698e3cb63bacc52d | [log] [tgz] |
---|---|---|
author | Trevor Perrier <perrier@chromium.org> | Mon Mar 07 23:10:01 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 07 23:10:01 2022 |
tree | 197a0e5fc7177a416dafcb0f046f42da920a4a88 | |
parent | 1c4cf087a8bf049fc4f8d5903de5007f91d757dc [diff] |
[locals] Build all locale resources This CL replaces |locales_with_pseudolocales| with |all_chrome_locales| in most grit targets (remoting and fuchsia targets are ignored for now). Doing this means that outputs for all pak file outputs need to be added to the header of all affected grd files. These resources are built but only those in |platform_pak_locales| are actually packed into each platforms binary. The following GRD files are exempt from this CL and will still require updating if the locales for the platform change: - chrome/app/resources/locale_settings_chromiumos.grd - chrome/app/resources/locale_settings_google_chromeos.grd - chrome/app/resources/locale_settings_linux.grd - chrome/app/resources/locale_settings_mac.grd - chrome/app/resources/locale_settings_win.grd - ios/chrome/app/strings/ios_strings.grd This is done to make sure that |platform_pak_locales| matches what is expected for each platform. This still greatly simplifies the grd build and makes it easier to add more locales to individual platforms. This CL makes no changes to the locales that are actually shipped on each platform. Some extra work is added to the build for the unshipped locales, but looking at bot build times this is not noticeably significant. The only string changes done in this CL are removing whitespace at the end of messages. EOL whitespace in the middle of messages is not removed so that new message ids are not created. Bug: 1293908 Change-Id: I252e0ab410676b15ebb9849ae8c770dcb050abf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3498882 Reviewed-by: Michael Cui <mlcui@google.com> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Owners-Override: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by: Claudio M <claudiomagni@chromium.org> Cr-Commit-Position: refs/heads/main@{#978496}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.