[aim][popup] Remove visibility assert from setPreserveContextOnClose_

Addresses the "Uncaught Error: Assertion failed
(chrome://omnibox-popup.top-chrome)" JS error reports tracked in
https://crbug.com/558982300, which started in M152.

crrev.com/c/8071569 made `addContext_()` reset `preserveContextOnClose_`
by calling `setPreserveContextOnClose_(false)`. That method asserts
`document.visibilityState === 'visible'`.

The browser sends `AddContext` whenever the popup state is `kAim`
(`OmniboxContextMenuController::UpdateSearchboxContext()`), not based on
actual page visibility. The renderer's visibility state is updated over
a separate channel and can also be affected by occlusion, so
`AddContext` can be delivered while the document is hidden, and the
assert throws.

The browser-initiated `SetPreserveContextOnClose` call is gated the same
way, so the assert does not describe a real invariant. Remove it. Adds a
test that delivers `addContext` while the document is hidden; it fails
with "Assertion failed" without this fix.

Bug: 558982300
Change-Id: I4ff09e9b6c89340fa87728c6057bdbd18ce60b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8466742
Auto-Submit: Aviv Kiss <avivkiss@google.com>
Reviewed-by: Paul Adedeji <pauladedeji@google.com>
Commit-Queue: Paul Adedeji <pauladedeji@google.com>
Cr-Commit-Position: refs/heads/main@{#1707088}
2 files changed
tree: d1159558c793543b3ef5347b789c239ce8cd1bcd
  1. .agents/
  2. .claude/
  3. .gemini/
  4. .github/
  5. agents/
  6. android_webview/
  7. apps/
  8. ash/
  9. base/
  10. build/
  11. build_overrides/
  12. buildtools/
  13. cc/
  14. chrome/
  15. chromecast/
  16. chromeos/
  17. codelabs/
  18. components/
  19. content/
  20. crypto/
  21. dbus/
  22. device/
  23. docs/
  24. extensions/
  25. fuchsia_web/
  26. gin/
  27. google_apis/
  28. gpu/
  29. headless/
  30. infra/
  31. ios/
  32. ipc/
  33. media/
  34. mojo/
  35. net/
  36. pdf/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webkit/
  52. .clang-format
  53. .clang-tidy
  54. .clangd
  55. .cursorignore
  56. .geminiignore
  57. .git-blame-ignore-revs
  58. .gitallowed
  59. .gitattributes
  60. .gitignore
  61. .gitmodules
  62. .gn
  63. .mailmap
  64. .rustfmt.toml
  65. .yapfignore
  66. ATL_OWNERS
  67. AUTHORS
  68. BRANCH_FEATURE_OWNERS
  69. BRANCH_OWNERS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. package.json
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. vpython.toml
  87. vpython.toml.uv.lock
  88. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.