Google Git
Sign in
chromium / chromium / src / 0aef380f1fd583650fd9a825d794c59507debc2c
commit0aef380f1fd583650fd9a825d794c59507debc2c[log] [tgz]
authorWenyu Fu <wenyufu@google.com>Tue Nov 28 18:46:57 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 28 18:46:57 2023
tree07d3de6a0ffeb87d60cf1f68a181ecebe369b4fb
parent68a7863c94cbe65303d4efa6354b3ef21fbc2ff6 [diff]
Reland "[DTC] Toggle tab strip visibility"

This reverts commit fa86829e9e25d737e8b85455107dd1a2ef0facf2.

Reason for revert: Reland with fixes:

* Fix issue when top control holds a wrong height during theme changes by reading toolbar height from resource;
* Fix NPE error during test by properly remove observers
* Fix integration test failure by change test-only screen width bucket to avoid integer overflow


Original change's description:
> Revert "[DTC] Toggle tab strip visibility"
>
> This reverts commit 4fad5ff4bb1a1d460fef2a767dc332fd093b7a55.
>
> Reason for revert: Causing test failures on CI. Commented on original bug here: crbug.com/1498252
>
> Original change's description:
> > [DTC] Toggle tab strip visibility
> >
> > Use the BrowserControlsManager to hide / show tab strip when window width go below 600dp. Currently the render initiated animation is not handled well for the top toolbar.
> >
> > Demo recording see crbug.com/1498252#c2.
> > Design: https://docs.google.com/document/d/1AoTOVrA-5T7dPfRG7X3xVkjWmmJ5q6kBXg024cvlUS8/edit?resourcekey=0-3vNxjwqPaXGSa1Geo6JQyg#bookmark=id.3lyu2mfuogf9

Bug: 1498252, 1503013
Change-Id: I6605821198535322be3c4995ff900fdc017a1281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041712
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1230063}
13 files changed
tree: 07d3de6a0ffeb87d60cf1f68a181ecebe369b4fb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.