Google Git
Sign in
chromium / chromium / src / 0b128880e9a9cd602d3b76f4ac2a5d96e28523bb
commit0b128880e9a9cd602d3b76f4ac2a5d96e28523bb[log] [tgz]
authorCharlie Harrison <csharrison@chromium.org>Fri May 25 21:40:20 2018
committerCommit Bot <commit-bot@chromium.org>Fri May 25 21:40:20 2018
tree5077b11c2f340f9d79d115330dd0fb1a59512149
parente04ac9cea715469f0a2d5983cfb34c1c3d17161a [diff]
Minor popup blocker cleanups

This CL:
1. Stops null-checking the WebContents when considering to block popups.
   All callers pass in a valid contents already.

2. Tests the case when a caller calls ShowBlockedPopup with an invalid
   id. This seemed like a more reasonable API to be defensive with, but
   it wasn't tested.

Bug: None
Change-Id: I3913ed540b06f57e7fd31cae1f7da7de4da37dab
Reviewed-on: https://chromium-review.googlesource.com/1073847
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562022}
2 files changed
tree: 5077b11c2f340f9d79d115330dd0fb1a59512149
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .