Google Git
Sign in
chromium / chromium / src / 0b14f5ae808371c36b74d3a914280c872d7a6ba6
commit0b14f5ae808371c36b74d3a914280c872d7a6ba6[log] [tgz]
authorAaron Leventhal <aleventhal@google.com>Fri Mar 07 22:01:26 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Mar 07 22:01:26 2025
tree38eacf58839c4ceadc78d57e17f1472c22f65101
parent9b2cebcecbf26bd0545b4273b97061b371fee6d7 [diff]
[A11y] Use correct screen reader signal in browser_view

In the upstream CL (https://chromium-review.googlesource.com/c/chromium/src/+/6331102) we renamed
AXMode::kScreenReader to what it actually does. Because of
it's incorrect name, it was being misused to detect the
presence of a screen reader.

This CL uses the new signal for screen reader usage, which
should match the original intention of the code. Without this
change, there would be many false positives.

We're going to need to do a lot of these types of fixes.
The process will be to audit the sites that changed from
AXMode::kScreenReader to kExtendedProperties in CL:6331102,
and if they are actually trying to detect a screen reader,
use the new BrowserAccessibilityState method instead.
We have to be careful, however. If the method is going to be
called a lot, we may want to cache the result somehow.

Bug: 401443089
Change-Id: I462e2a70de1c4483f51ea6b342df1e892cd5b0a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6336045
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429743}
4 files changed
tree: 38eacf58839c4ceadc78d57e17f1472c22f65101
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.