Use the bitmap acceleration instead of raster mode in ShouldApplyNoise

The CanvasInterventionsHelper was using the raster mode of the canvas
to determine whether noise should be added. The raster mode was
queried using CanvasResourceHost::GetRasterMode(). This function uses a
somewhat convoluted heuristic to determine the raster mode [1]. In
particular, it tries to predict what the raster mode would be if we do
not yet have a resource provider. This can happen if the canvas is
newly created, or if the GPU context was lost. Moreover,
HTMLCanvasElement and OffscreenCanvas have different heuristics in
these cases and will possibly return different values.

It seems that a far simpler and more robust approach would be to
directly check whether the snapshot bitmap is accelerated. The bitmap
is accelerated if and only if the canvas itself is accelerated.

[1]: https://crsrc.org/c/third_party/blink/renderer/platform/graphics/canvas_resource_host.cc;l=100;drc=352fbdae1017811d80b9d0d10a28464e24fae395

Bug: 346766781
Change-Id: Ic209d8498b19c91170ab58bcf3e50842fc449242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6440837
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Reviewed-by: Tom Van Goethem <tov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1445674}
6 files changed
tree: 1fb3b1e1477439dfc98525bb71d0440c9f7d34af
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.