commit 0b51a168118d415de8985ff12e34e8f91eee4cd6
author Matt Reichhoff <mreichhoff@chromium.org> Thu Jan 16 16:50:32 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jan 16 16:50:32 2025
tree 4a36c960948c214c912a006b28821511d40fb1c4
parent 06821256f2ce11692c958d3195c1f1be6c5d57f4

Revert "Replace raw_ptr/* to VideoCaptureController with scoped_refptr."

This reverts commit e0d884498a10fc9e992f70a27b1a50847c736170.

Reason for revert:
Causes test failures; see:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/49298/test-results?sortby=&groupby=

Original change's description:
> Replace raw_ptr/* to VideoCaptureController with scoped_refptr.
>
> Raw pointers increase risk of UAF and begs lifetime questions. In order
> to improve code health, we replace all raw pointers to the
> VideoCaptureController with scoped_refptr.
>
> This gives up some freedom as to when VideoCaptureController is
> destroyed or on what thread this happened, since a scoped_refptr could
> be bound on a task being posted. By adding some DCHECKs in its
> destructor, we ensure this isn't a problem:
> - We should already have "cleaned everything up" (e.g. removed clients
>   and devices) by the time we release the last reference to the
>   controller).
>
> While this assumption appears to hold in practice (as per manually
> running Chrome and opening and closing the camera), the unit tests were
> not very good at cleaning things up so they are updated accordingly.
>
> Bug: 385089402
> Change-Id: Ib88a1b800220564258493866ce0f7d4ba5dbb960
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110734
> Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1407230}

Bug: 385089402
Change-Id: I976aee9f3a7c60e7e12d0e5440a14705a388f3c3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6175714
Owners-Override: Matt Reichhoff <mreichhoff@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Matt Reichhoff <mreichhoff@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1407349}