commit e063b6910efcc5bd78d8c2017d68696613b338c1
author Tommy C. Li <tommycli@chromium.org> Tue May 21 17:56:32 2019
committer Commit Bot <commit-bot@chromium.org> Tue May 21 17:56:32 2019
tree 6c8feac05b0f9edb34913e706ab6ff5112e62717
parent b3dcd2b61ca8eb3b6d2f4a35f7e16b0a9d7cb691

[omnibox] Remove cached tint_ from LocationBarView

The cached tint_ member variable has been causing us issues for the last
month or so, since Views get theme change notifications from
child-to-parent.

LocationBarView doesn't know to update its cached tint until it gets
a notification, but that occurs after the children get notifications.

Good news is that the tint calculation has been optimized substantially
by this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1565063

Now it takes ~7us to calculate intsead of ~15us.

So maybe we don't need to cache the tint_ after all.

Bug: 962923
Change-Id: I6b630eb4ccec5377aec58b53dad8a1f24ae977c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621246
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661810}