Google Git
Sign in
chromium / chromium / src / 0c28265994dbfa2ff58d3fd36d7ad9184890cc59
commit0c28265994dbfa2ff58d3fd36d7ad9184890cc59[log] [tgz]
authorJunji Watanabe <jwata@google.com>Mon Jul 01 17:50:14 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jul 01 17:50:14 2024
treef7f0657fe162da581b2b7a83f751225ada43071c
parent6c70963cb40e31720bdc6916a9f8733c9dd70e84 [diff]
Revert "Enable LTO in PGO-instrumented builds"

This reverts commit 223328473bcdcb77ef8ba4fd362bb261d0f09a51.

Reason for revert: It's suspicious to break win32-pgo.

https://ci.chromium.org/ui/p/chrome/builders/ci/win32-pgo/9550/overview
> lld-link: error: <unknown>:0: assembler label 'L?CopyParamIn@?$ActualCallParams@$02$0EAA@@sandbox@@QAE_NIPBXI_NW4ArgType@2@@Z$frame_escape_0' can not be undefined

See https://crbug.com/349104633#comment8 for the repro steps.

Original change's description:
> Enable LTO in PGO-instrumented builds
>
> This was temporarily reverted in https://chromium-review.googlesource.com/c/chromium/src/+/3020266
> and never made it back.
>
> I see a 1% speedometer improvement (vs. a baseline locally-gathered
> profile) locally.
>
> Bug: 345518602
> Change-Id: I8937893bd5b5ad268773bce6565645835a30bafd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5604930
> Commit-Queue: Leonard Grey <lgrey@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1314000}

Bug: 345518602, 349104633
Change-Id: I10e8c460b62673806d63ef32e0bf040863952718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5670644
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1321745}
1 file changed
tree: f7f0657fe162da581b2b7a83f751225ada43071c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.