commit 0ca1f148d8dd91f31e1976a6bae521173304ee27
author Alex Gough <ajgo@chromium.org> Mon Jul 15 19:24:02 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 15 19:24:02 2024
tree 91fd2e26eeb44437046d86c42010901dd75ed6f6
parent 448cc1dcde6d6cbff09d34ad7266dc0fa6ea788e

Turn iterator _!=_.end() DCHECK() into CHECK() for components/infobars

Accessing an invalid iterator can sometimes be a security
issue and these checks are cheap, so upgrade to CHECKs.
Generally these DCHECKS precede a use or erase of the
checked iterator, which if the check is invalid (ie. the
iterator == .end()) is UB.

For this CL instances were located with a weggli query:

```
weggli --verbose=1 --cpp \
         'DCHECK(_ != _.end());' \
      -p 'DCHECK(_.end() != _);' \
      -p 'DCHECK_NE(_, _.end());' \
      -p 'DCHECK_NE(_.end(), _);'
```

which should avoid any potentially expensive calculations
of the thing to be matched against .end().

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug: 351745839
Change-Id: I3d1476d0999e6073775dcc60ed4d2efbc61a1a45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5704264
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1327713}