[omnibox][spark] Cancel auth request on `Stop()`

The provider's async flow is:
1) provider `Start()` is called, which pushes `Run()` into the debounce
   queue
2) Debounce fires `Run()` which starts the auth request
3) Auth request returns and actual request is sent
4) Actual resust returns and the provider's matches are updated

`Stop()` will cancel the debounce queue (1) and the actual request (3).
But it won't cancel the auth request (2). So if we're in state (2) when,
e.g. the omnibox is closed, the auth request will continue. When it
returns, steps (3) & (4) will continue. (4) has a `DCHECK` to make sure
the provider hasn't stopped, i.e. `done_` is false. This `DCHECK` will
crash local dev builds. But real consumer builds will continue and
possibly see unexpected behavior (e.g. maybe the omnibox they closed
reopens when the matches are updated).

This CL updates `Stop()` to cancel any ongoing auth requests.

NO_IFTTT=false positive on introduction of LINT.IfChange

Bug: 414625919
Change-Id: I7a0b4c072fbd2a06db75f951bbc5028bfb24c13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6499512
Reviewed-by: Ananya Seelam <ananyaseelam@google.com>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1454143}
7 files changed
tree: ff4a5ccdbff2a169afc1c356fa6214e6ee5f4aa4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.