Google Git
Sign in
chromium / chromium / src / 0d19d019934ff13438dbaad6545e77a26c32b1b2
commit0d19d019934ff13438dbaad6545e77a26c32b1b2[log] [tgz]
authorMario Sanchez Prada <mario@igalia.com>Fri Jan 10 23:19:06 2020
committerCommit Bot <commit-bot@chromium.org>Fri Jan 10 23:19:06 2020
treeac4b01bd915f0d3f58200f5974289af97935fcee
parent9d89754815421abab87c648d059b85db23e56368 [diff]
Add extra null-checks for return value of WebContents::FromRenderFrameHost()

The result value of WebContents::FromRenderFrameHost() can be a nullptr if
the RenderFrameHost's delegate is not a WebContents, so we need to add this
extra check in all the binders method that still don't have it to prevent
potential crashes.

Bug: 936482,1006361, 1040649
Change-Id: I688015361d34ec50e43feac0b88053159fbe941c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995161
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#730338}
1 file changed
tree: ac4b01bd915f0d3f58200f5974289af97935fcee
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .