Google Git
Sign in
chromium / chromium / src / 0d1b134e030842b994387c422eded32d9c4e928b
commit0d1b134e030842b994387c422eded32d9c4e928b[log] [tgz]
authorChristopher Cameron <ccameron@chromium.org>Mon Apr 08 19:40:10 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 08 19:40:10 2024
treef4fc7adbf1e495620fc63d0c4b083573eb199f62
parent57f2d3610fec942345b40dc47c35a9a105ca80ce [diff]
cc/viz: Draw less often during HDR transitions

The cc::Layer::RequiresSetNeedsDisplayOnHdrHeadroomChange function
returns true if a change in HDR headroom will require that a layer
be re-drawn.

This affects only macOS, where HDR headroom will rapidly fluctuate,
and it is important to avoid unnecessary re-draws.

This was only implemented for cc::PictureLayer, and a TODO was left
behind for cc::TextureLayer. Implement the function for
cc::TextureLayer, and add tests.

Rename gfx::DisplayColorSpaces::EqualExceptForHdrParameters to
EqualExceptForHdrHeadroom, and make the function return false if
the SDR white level changes (since that's a very different problem,
at least for now).

Also change ui::Compositor::SetDisplayColorSpaces to not force a
redundant re-draw when only the HDR headroom changes (headroom-only
changes will not force buffer reallocation).

This significantly reduces the amount of work that will be done during
HDR headroom transitions, although further reduction is also possible.

Bug: 329479347
Change-Id: Ife8919d803fc10891ffa0ecfd26f75519ca4c8e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5419373
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1284037}
6 files changed
tree: f4fc7adbf1e495620fc63d0c4b083573eb199f62
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.