Google Git
Sign in
chromium / chromium / src / 0d3df6e83dbffeff684fdb590a449bb43368e7c9
commit0d3df6e83dbffeff684fdb590a449bb43368e7c9[log] [tgz]
authorAliona DANGLA <alionadangla@google.com>Mon Feb 05 18:38:22 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Feb 05 18:38:22 2024
treede36d9a5f8a114f950d6ec4d156e2e67c56935f9
parent2e331803aa124b525db7a79ebbf61904db366cd6 [diff]
[iOS] Apply safe area inset to the web view

When going on landscape mode the safe area is not respected so dedicated
landscape websites are hidden under the notch and lead to have
inaccessible area. To fix that, apply the safe area to the web view
directly at creation and at all updates to ensure this is taken into
account.

See videos:
https://drive.google.com/file/d/1c9hScQhA1l3mYUs38qZ5V0jCLawgFdsR/view?usp=drive_link
https://drive.google.com/file/d/1WetT-OHjfGKuzzV1yiV-qcnBMc70Nj2g/view?usp=drive_link

Also to avoid regression, this CL also add a way to manage a specific
CSS value "viewport-fit=cover" so the web view take the entire screen.
This is a known bug see crbug.com/1394631 and crbug.com/1150075 for more
infos.

See videos:
https://drive.google.com/file/d/1bqSNodi6thyAPDCskTiFN4buarYHjn9d/view?usp=drive_link
https://drive.google.com/file/d/1b_ov445QRtPXDjuOihJJqnncep8t5g1Z/view?usp=drive_link

Pair-programming: ajuma@

Fixed: 1504344, 1394631, 1253344
Change-Id: Ie2c79e31ecd76ce10fb886996a68213eebed748f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185799
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Aliona Dangla <alionadangla@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1256303}
10 files changed
tree: de36d9a5f8a114f950d6ec4d156e2e67c56935f9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.