Google Git
Sign in
chromium / chromium / src / 0d458fbe0ed08060e2734e2ff5f63326e77d77e4
commit0d458fbe0ed08060e2734e2ff5f63326e77d77e4[log] [tgz]
authorJunhui He <junhuihe@google.com>Tue Jun 27 21:56:12 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 27 21:56:12 2023
treef4000ba06fb11ec70263b47918861d0bd115f28a
parentf4f568e3c22eabc84ff5fd5a0acdf8f23cad95b3 [diff]
[Clank][UX Enhancements] Make the challenge option logo as secondary text, also allow the challenge option icons to respect light/dark mode

For Mock and Before, didn't paste the SMS OTP case since it's behaving similar to email OTP one. For After, included both cases.

Mock:
https://screenshot.googleplex.com/8ZowkfthtocKP8H.png

Before:
(light mode) https://screenshot.googleplex.com/65ARCsnnVkBhBHm.png
(dark mode) https://screenshot.googleplex.com/AL3xxqpuWp6KgnH.png

After:
(light mode)
https://screenshot.googleplex.com/6MLZeLf8AJDy2ce.png
https://screenshot.googleplex.com/LZELBvNBM5pGhQG.png
(dark mode)
https://screenshot.googleplex.com/6HFUVvRE5iWbk2R.png
https://screenshot.googleplex.com/AyuvG2WoLBAU47M.png



Bug: 1457093
Change-Id: I0afce64772737521e0a9bd7c3bdd5fceb8d742de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4637592
Reviewed-by: Christoph Schwering <schwering@google.com>
Reviewed-by: Vishwas Uppoor <vishwasuppoor@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Junhui He <junhuihe@google.com>
Cr-Commit-Position: refs/heads/main@{#1163244}
2 files changed
tree: f4000ba06fb11ec70263b47918861d0bd115f28a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.