Google Git
Sign in
chromium / chromium / src / 0d747cd65ef03260f28c0d214af1ce541d0e532c
commit0d747cd65ef03260f28c0d214af1ce541d0e532c[log] [tgz]
authorYuwei Huang <yuweih@chromium.org>Mon Mar 28 18:49:09 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Mar 28 18:49:09 2022
treeac5c00c5dccf4ed3e4da4ad48876c7a266f92b83
parentf7f91c43cd6cca3af3f140c10ead1b0ef9e117b0 [diff]
[remoting host][open url] Convert file path back to file URL

It appears that in some Linux environments a file:// URL will be
converted to an absolute file path when it's being passed to the
remote_open_url binary. This CL converts such path back to a file:// URL
and open it using the fallback browser.

We could technically just pass the argument string to
RemoteOpenUrlClient::Delegate::OpenUrlOnFallbackBrowser() directly, but
that requires changing a few platform-specific implementations, so I've
found it easier to just convert the path back to a file:// URL.

Bug: b/226384663
Change-Id: Ie0b25ebde95360b53fba3c803ab50afd9935a770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551873
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/main@{#986069}
4 files changed
tree: ac5c00c5dccf4ed3e4da4ad48876c7a266f92b83
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.