Google Git
Sign in
chromium / chromium / src / 0e0fe0ad2b6ec2c32e96d15b51fdee949c726e83
commit0e0fe0ad2b6ec2c32e96d15b51fdee949c726e83[log] [tgz]
authorDaniel Cheng <dcheng@chromium.org>Wed Apr 27 08:40:34 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 27 08:40:34 2022
treeceed8f47c124ca2036397fc8619df33829b71c5f
parent479e8ea53aa400c86d870c435ef14fc0ecff9369 [diff]
Remove use of "generic" MojoUnion::New() helper in //chrome/services/sharing/nearby

The New() method for unions has a generic-sounding name but actually
creates a union containing the first declared subtype. In general, this
behavior is non-intuitive; it can even give the impression that it
creates an empty union that doesn't contain any of its subtypes.  It is
also inefficient: many uses of the New() method immediately populate a
different subtype, so the initial allocation to hold the first declared
subtype is simply allocator churn.

For these reasons, usage of MojoUnion::New() is being phased out and
removed.

This CL was uploaded by git cl split.

R=hansberry@chromium.org

Bug: 1261169
Change-Id: Ia704de42074bed4d33c7b6de345f1e9c616cb18e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3601888
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#996589}
1 file changed
tree: ceed8f47c124ca2036397fc8619df33829b71c5f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.