Google Git
Sign in
chromium / chromium / src / 0e3de80b1bb55ed72fe14d1f8f8872d877731b7f
commit0e3de80b1bb55ed72fe14d1f8f8872d877731b7f[log] [tgz]
authorMatthias Körber <koerber@google.com>Mon Nov 29 23:23:32 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Nov 29 23:23:32 2021
tree6c122399960ae00f957c1e5d99e6033b386e0efe
parent7ca4d27e14fc47ff533df1ebbb6400cbd17ef787 [diff]
[BubbleBorder] Condition arrow placement on sufficient space on bubble

This CL fixes a crash in AddArrowToBubbleCornerAndPointTowardsAnchor.
When called with a insufficiently sized bubble, a call to base::clamp
results in a CHECK violation.

With this CL, the placement of the arrow in conditioned on having
sufficient space. If not, the function returns false.

An alternative is to extend the size of the bubble, but sizing should be
the responsibility of the caller and not of the border.

Bug: 1273560
Change-Id: Icb329eff74f5d535808fdc4eb8c55ca28ebab3e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3302303
Commit-Queue: Matthias Körber <koerber@google.com>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/main@{#946202}
4 files changed
tree: 6c122399960ae00f957c1e5d99e6033b386e0efe
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.