| commit | 0e4a88f4294597ca9f1f39f99dd71b3915ed6f32 | [log] [tgz] |
|---|---|---|
| author | Andres Salomon <dilinger@queued.net> | Fri Sep 30 01:44:38 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Sep 30 01:44:38 2022 |
| tree | db4926117fb0f65b1435b9abf10e408a4f93df73 | |
| parent | 8afb3eabd598c9aa6fdbdacefed39be08a2c9812 [diff] |
Fix non-neon ARM builds of libaom Linking fails when building chromium for non-NEON ARM w/ the following: ld.lld: error: undefined symbol: aom_arm_cpu_caps >>> referenced by av1_rtcd.h:1055 (../../third_party/libaom/source/config/linux/arm/config/av1_rtcd.h:1055) >>> libaom/av1_rtcd.o:(.text+0x0) in archive obj/third_party/libaom/libaom.a >>> referenced by aom_dsp_rtcd.h:3476 (../../third_party/libaom/source/config/linux/arm/config/aom_dsp_rtcd.h:3476) >>> libaom/aom_dsp_rtcd.o:(.text+0x0) in archive obj/third_party/libaom/libaom.a >>> referenced by aom_scale_rtcd.h:162 (../../third_party/libaom/source/config/linux/arm/config/aom_scale_rtcd.h:162) >>> libaom/aom_scale_rtcd.o:(.text+0x0) in archive obj/third_party/libaom/libaom.a The function aom_arm_cpu_caps() in third_party/libaom is used inside of several libaom header files, and is used by all arm boards to actually determine the running CPU capabilities. As such, arm_cpudetect.c needs to be included in sources for all arm boards, not just ones that support NEON. The full build log for the original failure can be seen here: https://buildd.debian.org/status/fetch.php?pkg=chromium&arch=armhf&ver=99.0.4818.0-0.1&stamp=1642756579&raw=0 Debian is now using this patch, which succeeds and allows libaom to be built properly for both our arm64 and armhf architectures: https://buildd.debian.org/status/fetch.php?pkg=chromium&arch=arm64&ver=106.0.5249.61-1&stamp=1664422573&raw=0 https://buildd.debian.org/status/fetch.php?pkg=chromium&arch=armhf&ver=106.0.5249.61-1&stamp=1664355966&raw=0 R=jzern@chromium.org Change-Id: I08e6ddbaf43d7de6575720911fa073ec1b7c8303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3926048 Reviewed-by: James Zern <jzern@google.com> Commit-Queue: James Zern <jzern@google.com> Auto-Submit: Andres Salomon <dilinger@queued.net> Cr-Commit-Position: refs/heads/main@{#1053334}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.