commit | 0e8652fc58eab4a5c450c4bf6ebc702348bba9cd | [log] [tgz] |
---|---|---|
author | Charles Hager <clhager@google.com> | Fri May 17 22:30:06 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 17 22:30:06 2024 |
tree | 14af5eaa75cdbc16dd4002f8c64ba60c50749afb | |
parent | 16ca2c64fa141231b03afd5b34c4a36902fb6357 [diff] |
Force show divider for partial width bottom-attached UI Currently, the BottomAttachedUiObserver will watch bottom-attached UI and pass along a color signal to set the OS navbar color to match any UI bordering the bottom of the tab. When matching the web content background, or this bottom-attached UI, the divider is set to the same color for a polished, streamlined look. This looks a bit odd when the bottom-attached UI doesn't extend the full width, which can happen on landscape orientation or large devices (i.e. tablets), when the screen is over a certain width. For these cases, Chrome should show the divider. Overlay panel: https://screenshot.googleplex.com/7JERBcXSYwiW5Pa.png Overlay panel (tab group): https://screenshot.googleplex.com/6pDnr7okTPLyfMb.png Bottom sheet: https://screenshot.googleplex.com/B5vhphZAhkSpiGo.png Tablet: https://screenshot.googleplex.com/8SH7dcTEWDGnAsY.png https://screenshot.googleplex.com/9n7fhW3RzWg7UnG.png Demo: https://screencast.googleplex.com/cast/NjIyMjYzOTYyOTU5ODcyMHxlNDM2Mzc3My0xZA Bug: 339309811 Change-Id: I4f83d47a7419e5eab3d4029a6fb79467d468c95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532728 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Wenyu Fu <wenyufu@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Charles Hager <clhager@google.com> Cr-Commit-Position: refs/heads/main@{#1302888}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.