commit 0e89052e76cfb46ce2f5d5e852924d071192facb
author Aishwarya Rajesh <aishwaryarj@google.com> Tue Sep 10 19:41:42 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 10 19:41:42 2024
tree 6bc5e835b850da8cf1354377f674bea1669654f1
parent 1b97c6a5a2ebf5eb47314984e9da96cf8ffb7751

[TSLO] Update app modal dialog layout to avoid drawing in app header
area

This CL passes the InsetObserver to the ModalDialogManager instance
maintained by ChromeActivity to access the activity's raw system bar
insets when they are applied, to determine the minimum horizontal and
vertical margins to use relative to the window to avoid drawing into any
insets' regions. Note that the insets will be retrieved from the
activity window because the dialog window currently does not return the
expected system bar insets.

These margins will be used when the view is measured to determine
the correct size. This custom measurement will be done only for normal
(ie. non-fullscreen) dialogs.

The CL also accounts for new layout constraints as follows:
- Dialog maintains 16dp from the window edges.
- Dialog can be a maximum of 600dp (requires further follow-up tracked
in b/359976267).

The above changes are guarded behind ModalDialogLayoutWithSystemInsets.

TODO: b/359973775, b/359976267

Demo:
https://screencast.googleplex.com/cast/NTgxNDkwOTk5NTU4MTQ0MHxkNDViMzM3MC1mYQ

Bug: 339304231, 359973775
Change-Id: I3d4cd59a1c0acdba046a777e3d2027784ca6f147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5753151
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Aishwarya Rajesh <aishwaryarj@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Reviewed-by: Lijin Shen <lazzzis@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1353538}