Google Git
Sign in
chromium / chromium / src / 0e928dda8d1a0e55191cfc82ec9e703891119ba1
commit0e928dda8d1a0e55191cfc82ec9e703891119ba1[log] [tgz]
authorVictor Hugo Vianna Silva <victorvianna@google.com>Thu Jul 06 15:36:03 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 06 15:36:03 2023
tree749aaf68cd1400d52f1a781b3b59584167bc69ab
parente4764445866ca97882de520875dfe1219fbfc254 [diff]
[M116] Remove "AndEnableSync" from SettingsSignInAndEnableSyncRowMatcher()

No behavior changes, just renaming.
I introduced this matcher in crrev.com/c/4582058. In next CLs, when
kReplaceSyncPromosWithSignInPromos is enabled, this matcher will
represent a row that leads to sign-in without enabling sync. So we
need to make the name slightly more generic.

(cherry picked from commit 856dc485d5b1739efefc59756419fe57d4a5ace2)

Bug: 1447012
Fixed: 1462514
Change-Id: I894d1989c96022bbf9446a5e979e7b7533f4ed09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4628122
Auto-Submit: Victor Vianna <victorvianna@google.com>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Quick-Run: Victor Vianna <victorvianna@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1160646}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4667239
Reviewed-by: Scott Yoder <scottyoder@google.com>
Owners-Override: Scott Yoder <scottyoder@google.com>
Commit-Queue: Scott Yoder <scottyoder@google.com>
Cr-Commit-Position: refs/branch-heads/5845@{#342}
Cr-Branched-From: 5a5dff63a4a4c63b9b18589819bebb2566c85443-refs/heads/main@{#1160321}
10 files changed
tree: 749aaf68cd1400d52f1a781b3b59584167bc69ab
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.