Google Git
Sign in
chromium / chromium / src / 0e998e395bc349b41af06c4bcb8ec11b39f1fefc
commit0e998e395bc349b41af06c4bcb8ec11b39f1fefc[log] [tgz]
authorSidney San Martín <sdy@chromium.org>Sat Dec 01 01:03:40 2018
committerCommit Bot <commit-bot@chromium.org>Sat Dec 01 01:03:40 2018
tree0570e19e5932be3725807126d31cba7f083860d2
parent09bb5f10ed625caa1f375374ff0004b6cf2c906f [diff]
[Mac] Validate the selection range before using it for text suggestions.

It looks like Blink can report an invalid selection range back to the
browser. This change treats invalid ranges like the empty string for the
purpose of generating suggestions, and adds a DCHECK for this condition.

Bug: 893038
Change-Id: I2afa5065d7eeebb6cc61030277f86b488a69388b
Reviewed-on: https://chromium-review.googlesource.com/c/1351530
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612882}
2 files changed
tree: 0570e19e5932be3725807126d31cba7f083860d2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .