commit 0ee606250a72bccf5a979a278ad26ec1d3c17fb9
author Calder Kitagawa <ckitagawa@chromium.org> Wed Jun 04 11:46:11 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jun 04 11:46:11 2025
tree 1e72c7067b35365c053d832eb76f4e6588ac9b79
parent 4565dea63e1cd9aca456f29e7b59bd8b40d3835d

Revert "[BCIV] Fix bug where tabstrip disappears during scroll"

This reverts commit 78633658189ddcde448701cf2497fbce5239812b.

Reason for revert: b/422256802

org.chromium.chrome.browser.usage_stats.TabSuspensionTest#testSuspendUninitializedCurrentTab

is failing on Tablet builders with a stack trace related to
composited UI and StripLayoutHelperManager. This CL seems the
most likely culprit in the blamelist.

Bug: 418046470
Original change's description:
> [BCIV] Fix bug where tabstrip disappears during scroll
>
> Currently, when StripLayoutHelperManager submits a frame to update the
> tabstrip, it passes the offset from the renderer to the compositor. If
> BCIV is enabled, we check if we're in a scroll, and if we are, we set
> the pass 0 as the offset to the compositor, and let viz apply the
> offset. However, it's not correct to check if we're in a scroll. We
> should be checking for the visibility constraints (as we are doing with
> other UI elements.)
>
> Checking if we're in a scroll was working fine, until a change was made
> that makes StripLayoutHelperManager submit a frame right after scrolling
> finished. This updated the offset to -height, which makes the tabstrip
> invisible, which causes the layer tree to hide the layers for the
> tabstrip. Then when we scroll back the tabstrip into view, the
> renderer's offset is applied to -height, instead of 0, which means we
> won't see the tabstrip on the screen.
>
> Bug: 418046470
> Change-Id: I2fe5ac6d0733bb10b96a502e8269263550aa833e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6614117
> Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
> Commit-Queue: Peilin Wang <peilinwang@google.com>
> Cr-Commit-Position: refs/heads/main@{#1468966}

Bug: 418046470
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Iae53e5418a63ac2ec2cb6c7730056903c96e94a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6621221
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1469221}