commit | 0ef9c84bde0c3a70e3ae41850030b185ce3ce22d | [log] [tgz] |
---|---|---|
author | Stephen Chenney <schenney@chromium.org> | Mon May 12 18:01:09 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 12 18:01:09 2025 |
tree | 883257d440fe55fcfcf6fee48916a24a7a44dddb | |
parent | 122e628a7d1d0dfe567f12218e1388126532d9eb [diff] |
Fix Canvas a11y fallback UKM reporting The HasPlacedElements check was inverted, thus meaning the UKM metric Accessibility.CanvasHasNonTrivialFallback has not been reported since this code landed. Add a test, so this doesn't happen again. Testing required adding a ukm recorder for DumpAccessibilityTreeTest which in turn required constructors, and setup/teardown methods. And also split out one test case to test for non-reporting. In theory we should report both positive and negative so that we can generate percentages. But then I suspect we would sample and reduce report counts, so do not do that until we have a better idea of how many reports this metric generates. AX-Relnotes: n/a Fixed: 416734649 Change-Id: Ib718d80de5b4d16941a75eae1c176504b6c0653c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6532530 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Mark Schillaci <mschillaci@google.com> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/main@{#1458958}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.