commit | 0f8b1b04adf5970522c68f6c07e4e6a76f0ef722 | [log] [tgz] |
---|---|---|
author | Timofey Chudakov <tchudakov@google.com> | Fri Dec 15 17:39:26 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Dec 15 17:39:26 2023 |
tree | b67cd1d44cef6c9c924b6162f6959cfdab643e0d | |
parent | 4766ba3ce2665d6daec874e1dadf1f6e1fdb42ba [diff] |
[Desktop] Remove PopupType::kPersonalInformation. PopupType::kPersonalInformation popup type is used when the user clicks on the form with fields like full name, email, phone number. However, this popup type is not handled differently anywhere except for 1 metric and 1 AX label. It affects the label of the suggestion that opens the relevant settings page, but the same settings page is opened for kAddresses popup type. Given that there're no major differences between kAddresses and kPersonalInformation popup types, this CL removes the latter. This change will affect Autofill.SuggestionsListManageClicked metric, namely the personal information and addresses buckets will be merged. Bug: b:316345315 Change-Id: Ic0d97559f7b90245e854f619b040275144e56c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5105949 Reviewed-by: Jan Keitel <jkeitel@google.com> Commit-Queue: Timofey Chudakov <tchudakov@google.com> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1238125}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.