Google Git
Sign in
chromium / chromium / src / 0f94fb87ec5702f0f11059af271037d870669b83
commit0f94fb87ec5702f0f11059af271037d870669b83[log] [tgz]
authorRohit Rao <rohitrao@chromium.org>Wed Sep 08 19:52:36 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 08 19:52:36 2021
tree01b63a181904854026ba6800966359b048dd1a5d
parent2452f4b92fbd4c9e5fce02ddd01324550060f786 [diff]
Fixes a DCHECK in BrowserViewWranglerTest.TestBrowserList.

SceneState stores a weak pointer to its UIWindowScene, which is usually
owned by the OS. When compiling for Release-iphonesimulator, the
FakeScene used in tests is dealloced before the test completes,
triggering a DCHECK() in -[SceneState sceneSessionID]. This CL makes the
test fixture responsible for owning the FakeScene, ensuring that it
survives throughout the test run.

BUG=None

Change-Id: I43f9593dba9da2068cee88add797ab6c45f36ab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149273
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919398}
1 file changed
tree: 01b63a181904854026ba6800966359b048dd1a5d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.