Google Git
Sign in
chromium / chromium / src / 0fa9d65fc391b7081c139fe9a905c3b3b65ef2ad
commit0fa9d65fc391b7081c139fe9a905c3b3b65ef2ad[log] [tgz]
authorRoland Bock <rbock@google.com>Tue Feb 25 17:48:00 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Feb 25 17:48:00 2025
tree15826b4356a1147f850db7bb506c7871219c73a3
parent2948ec67bfe00fb2167e5c2c62ba6fe6f9ef055e [diff]
[LTS-132] [Oobe] Block guest signin before state determination

This CL changes the initial enrollment determination state to block
guest signin during OOBE before state determination has concluded.

It also introduces a function to explicitly ask if guest signin should
be allowed (as opposed to guessing this from the current state). Apart
from improving readability, this will also make refactorings like
removing legacy state determination easier.

(cherry picked from commit 37804480cbeced8819b21918885eeeef4c2a0e1f)

Bug: b:393662127
Change-Id: I6e474c97a5aa4acea76c216ddd8796ed44b83b34
Tests: Manual confirmation and a new unit test
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6243938
Commit-Queue: Roland Bock <rbock@google.com>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1418216}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6280753
Cr-Commit-Position: refs/branch-heads/6834@{#5505}
Cr-Branched-From: 47a3549fac11ee8cb7be6606001ede605b302b9f-refs/heads/main@{#1381561}
4 files changed
tree: 15826b4356a1147f850db7bb506c7871219c73a3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.