commit | 0fe0ca9ef2f7ccde5165c01d4d59d3e4f442f5ae | [log] [tgz] |
---|---|---|
author | David Bokan <bokan@chromium.org> | Tue May 27 02:14:28 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue May 27 02:14:28 2025 |
tree | a46dcb92aa57ecbea83b98310b28c70a29b67744 | |
parent | 0dbf9a9143530270a1f828764ffa9a34f4ea598a [diff] |
Route actor tool calls to correct frame The CL implements basic routing of BrowserAction requests to the frame indicated by the ActionTarget's DocumentIdentifier. This identifier corresponds to a serialized UnguessableToken[1] stored as UserData on each RenderFrameHost from which an AnnotatedPageContent is extracted. A mapping of this serialized token back to RenderFrameHost is provided in the AIPageContentResult[2] but in the Glic context this is plumbed directly into a callback using the Glic mojo API[3] which this map shouldn't be stashed into. Given that we currently always act on the foreground tab (and the BrowserAction proto will eventually set the tab/task id), it seems low cost to iterate through the focused tab's RenderFrameHosts looking for the correct one. Eventually we'll probably want to extract this map from the context fetcher. [1] https://source.chromium.org/chromium/chromium/src/+/main:components/optimization_guide/content/browser/page_content_proto_provider.h;l=33;drc=46a97274045543958f5ff7fb0595bed79d265100 [2] https://source.chromium.org/chromium/chromium/src/+/main:components/optimization_guide/content/browser/page_content_proto_provider.h;l=64;drc=1f9f3d7d4227fc2021915926b0e9f934cd610201 [3] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/glic/host/context/glic_page_context_fetcher.cc;l=310;drc=1f9f3d7d4227fc2021915926b0e9f934cd610201 Bug: 419037299 Change-Id: Id6ce81462a54225e9b97b1892cea2f9d092ffc13 Cq-Include-Trybots: luci.chromium.try:linux-bfcache-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6579529 Reviewed-by: Kevin McNee <mcnee@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1465711}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.