[M152] [AW] Return null fingerprint if pseudo-partitioned link is not valid Original change's description: > [AW] Return null fingerprint if pseudo-partitioned link is not valid > > The partitioned database does not allow for creation of fingerprints > when the top level site or the frame origin are opaque. In > pseudo-partitioning, we simply cast the canonical_url into the top level > site and frame origin. If the canonical_url is an error page, then the > resulting created top level site will be opaque. > > This change returns a null fingerprint if the pseudo-partitioned link is > not valid (which would have opaque parts) and therefore does not mark > them as visited. This is a departure from the existing behavior of > WebView visited links (kWebViewMigrateVisitedLinks disabled), which > currently marks links such as about:blank as visited. However, there is existing logic (https://source.chromium.org/chromium/chromium/src/+/main:components/visitedlink/browser/visitedlink_writer.cc;l=326;drc=e7bc4320b65c2dca649bfdd0448a68ce1eb5823a) that supports the fact that invalid urls should not be saved to history. > > Change-Id: Ia80cad1fdbadad74dbbc73b784ad68b148320d54 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8186305 > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Kyra Seevers <kyraseevers@chromium.org> > Commit-Queue: Tiffany Song <tiffanysong@google.com> > Cr-Commit-Position: refs/heads/main@{#1675786} (cherry picked from commit a343a2822dcb98345ef4c03c607ab2d615823208) Bug: 544674093 Change-Id: Ia80cad1fdbadad74dbbc73b784ad68b148320d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8225852 Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7977@{#1123} Cr-Branched-From: b7fe14017379ddffae396d944fb8b59a5896c261-refs/heads/main@{#1669021}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.