Google Git
Sign in
chromium / chromium / src / 100f2df39698f03cd1819ea589313074c96a8d51
commit100f2df39698f03cd1819ea589313074c96a8d51[log] [tgz]
authorMark Yacoub <markyacoub@google.com>Tue Apr 19 18:01:14 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 19 18:01:14 2022
tree738052ca25446e532365740bcfeefb38b2665f04
parent9fb60219f7813b221b672574275842ec17beae03 [diff]
ui/display: Disable all monitors before modesetting after partitioning

[why]
When the configure display task starts partitioning the displays, it is
attempting to modeset each group of connectors based on their priority.
If this is due after a change of state, such as opening the lid while
external monitors were already running, the Configure Display Task
will start partitioning the connectors (assuming it failed to modeset all
together) and will attempt to modeset the eDP first before any external
monitor. This will fail as the monitors are currently taking the full
bandwidth, leaving no room for the eDP to be turned on.

[How]
When we partition, start with a disable request in the beginning that
turns off all displays, removing all resource allocation so each group
of connectors is now free to grab anything that's available.

TEST=kohaku(4k internal) + 2 4k displays turn on after close then open
the lid + ConfigureDisplaysTaskTest.CloseLidThenOpenLid.
BUG=b:208756849

Change-Id: Ie8016bc42075e6363a663d3a29704b976e0f0f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3579646
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Cr-Commit-Position: refs/heads/main@{#993788}
6 files changed
tree: 738052ca25446e532365740bcfeefb38b2665f04
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.