[XProto] Replace XAtom with x11::Atom

This CL removes XAtom from x11_types.h and replaces all usages with
x11::Atom.  This means that ui/gfx/x/connection.h needs to be included
everywhere x11_types.h was included, so it's just included from
x11_types.h directly.

This causes a problem: xproto_undef.h undefines a bunch of Xlib macros
like CopyFromParent, so these usages are replaced with "0 /*
CopyFromParent */" until further refactoring.  There are a couple of
cases where macros are not undefined (eg. Bool), so direct inclusions
of ui/gfx/x/x11.h are added to fix these.

Unfortunately, this CL introduces a lot of ugly static_cast's to
convert from x11::Atom to uint32_t for Xlib APIs, which will be
removed as usage of these Xlib APIs are removed.

I also fixed any clang-tidy warnings that showed up in my editor along
the way.

BUG=1066670
R=sky

Change-Id: Ifdc3c1a137a39cbbb37407e4299026c70da5281c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202789
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769975}
78 files changed
tree: 43d3f6461ca45cab1d42f1a07a6df8abec760d0d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.