Google Git
Sign in
chromium / chromium / src / 1029601b825e3e271cb6e4e21067bb625e46713c
commit1029601b825e3e271cb6e4e21067bb625e46713c[log] [tgz]
authorAndrew Xu <andrewxu@chromium.org>Tue Aug 02 20:58:26 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Aug 02 20:58:26 2022
tree666a14218865f9cbfe7e1d8c929db4ee9f383367
parentc392de5ff27c75e5ad2e7adaed67f8c6fce4973b [diff]
[Shelf] Use `LoginTestBase` in the login shelf pixel test

In this CL, `LoginShelfViewPixelTest` uses `LoginTestBase` as the
test base instead of `AshTestBase`. In addition, adding an extra
parameter to `AshTestBase::ShowLoginScreen()` to control whether
to set the wallpaper. Because the pixel test already sets the wallpaper,
in `LoginShelfViewPixelTest`, `AshTestBase::ShowLoginScreen()` should
not set the wallpaper again.

This CL also makes the test scenario more complex by checking the
focus traversal from the lock contents user view to the login shelf.

This CL should only affect tests.

Bug: 1347171
Change-Id: Id73b5ce4874a750d3bd230f51914fd6f2fec7df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3793567
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1030743}
4 files changed
tree: 666a14218865f9cbfe7e1d8c929db4ee9f383367
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.