Google Git
Sign in
chromium / chromium / src / 109db9583fd2dc424a9091c5d2d4055943a36007
commit109db9583fd2dc424a9091c5d2d4055943a36007[log] [tgz]
authorKurt Catti-Schmidt (SCHMIDT) <kschmi@microsoft.com>Thu Oct 20 01:56:12 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Oct 20 01:56:12 2022
tree9e1ca463df1685437ddfd6945765a0619c63395a
parentfaa395aca33f5438a90374cba59dc08279fec2d7 [diff]
[GridNG] Subgrid grid-area (implicit line support)

This change enables named grid-areas to properly work with subgrid.
It is very similar to the prior CL for named grid lines, with a few
key differences. Primarily, instead of discarding lines outside of the
subgrid range, implicit lines get clamped to the subgrid range.

In addition, this removes the `subgrid_offset` TODO and cleanly
brings the off-by-one error in `FirstExplicitPosition` that will
go away once `auto_repeat_total_tracks_` is properly accounted for.

Bug: 618969
Change-Id: I383997ab5acc7cf8e2e7ea326d173d51ac8bbe12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3958014
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1061365}
7 files changed
tree: 9e1ca463df1685437ddfd6945765a0619c63395a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.