Google Git
Sign in
chromium / chromium / src / 10b92753f18f0e597921c3a140f23e24ac1b0c97
commit10b92753f18f0e597921c3a140f23e24ac1b0c97[log] [tgz]
authorMuhammad Hasan Khan <mhasank@google.com>Mon Jun 10 18:50:48 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jun 10 18:50:48 2024
tree769d1f557c9641e664042630b231335389fe9bbf
parent53fb3cffb2572f9cd005487ba74b730529bc7873 [diff]
arc: Add success value to auth error metrics

The UMA metrics currently recorded for signin, checkin, and DPC errors,
do not have success as one of the values which makes it difficult to
determine if a certain error has started occurring more often in relation
to success.

UMA guidelines suggest that we have a baseline value in enums so we can
precisely avoid a problem like this where we can't compute the ratio of
success/failure if we only report errors.

Created a set of new UMA metrics that replace the old ones and has only
commonly occurring error values instead of all of the existing ones, in
addition to the new success value.

OBSOLETE_HISTOGRAM[Arc.Provisioning.CheckInError.Child]=Replaced by Arc.Provisioning.CheckinResult.Child
OBSOLETE_HISTOGRAM[Arc.Provisioning.CheckInError.DemoMode]=Replaced by Arc.Provisioning.CheckinResult.DemoMode
OBSOLETE_HISTOGRAM[Arc.Provisioning.CheckInError.Managed]=Replaced by Arc.Provisioning.CheckinResult.Managed
OBSOLETE_HISTOGRAM[Arc.Provisioning.CheckInError.OfflineDemoMode]=Replaced by Arc.Provisioning.CheckinResult.OfflineDemoMode
OBSOLETE_HISTOGRAM[Arc.Provisioning.CheckInError.RobotAccount]=Replaced by Arc.Provisioning.CheckinResult.RobotAccount
OBSOLETE_HISTOGRAM[Arc.Provisioning.CheckInError.Unmanaged]=Replaced by Arc.Provisioning.CheckinResult.Unmanaged
OBSOLETE_HISTOGRAM[Arc.Provisioning.CloudFlowError.Child]=Replaced by Arc.Provisioning.DpcResult.Child
OBSOLETE_HISTOGRAM[Arc.Provisioning.CloudFlowError.DemoMode]=Replaced by Arc.Provisioning.DpcResult.DemoMode
OBSOLETE_HISTOGRAM[Arc.Provisioning.CloudFlowError.Managed]=Replaced by Arc.Provisioning.DpcResult.Managed
OBSOLETE_HISTOGRAM[Arc.Provisioning.CloudFlowError.OfflineDemoMode]=Replaced by Arc.Provisioning.DpcResult.OfflineDemoMode
OBSOLETE_HISTOGRAM[Arc.Provisioning.CloudFlowError.RobotAccount]=Replaced by Arc.Provisioning.DpcResult.RobotAccount
OBSOLETE_HISTOGRAM[Arc.Provisioning.CloudFlowError.Unmanaged]=Replaced by Arc.Provisioning.DpcResult.Unmanaged
OBSOLETE_HISTOGRAM[Arc.Provisioning.SignInError.Child]=Replaced by Arc.Provisioning.SigninResult.Child
OBSOLETE_HISTOGRAM[Arc.Provisioning.SignInError.DemoMode]=Replaced by Arc.Provisioning.SigninResult.DemoMode
OBSOLETE_HISTOGRAM[Arc.Provisioning.SignInError.Managed]=Replaced by Arc.Provisioning.SigninResult.Managed
OBSOLETE_HISTOGRAM[Arc.Provisioning.SignInError.OfflineDemoMode]=Replaced by Arc.Provisioning.SigninResult.OfflineDemoMode
OBSOLETE_HISTOGRAM[Arc.Provisioning.SignInError.RobotAccount]=Replaced by Arc.Provisioning.SigninResult.RobotAccount
OBSOLETE_HISTOGRAM[Arc.Provisioning.SignInError.Unmanaged]=Replaced by Arc.Provisioning.SigninResult.Unmanaged

Bug: b:333128815
Fixed: b:333128815
Test: ./out_Default/Release/unit_tests
Change-Id: I5e67cfa67986c8a400b81d1c77e61fa8d7c18497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5610477
Reviewed-by: Yury Khmel <khmel@chromium.org>
Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org>
Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1312950}
6 files changed
tree: 769d1f557c9641e664042630b231335389fe9bbf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.