| commit | 10df808911580e41aefff1f53334bf1384aba77e | [log] [tgz] |
|---|---|---|
| author | Takuto Ikuta <tikuta@chromium.org> | Mon Jun 17 04:51:16 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 17 04:51:16 2024 |
| tree | d93998faaa0cee90ed006d85bb859a42ebc9116c | |
| parent | c073e6dcc028d442f9f382a9ed0d2f664144ba6a [diff] |
Revert "DEPS: update ninja to 1.12.1" This reverts commit 84dbf0b83eef8c2ad0fa94814cbe423d96e65b5e. Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/build/linux-chromeos-build-perf-ninja/910/overview https://ci.chromium.org/ui/p/chromium/builders/build/linux-build-perf-no-rbe/1690/overview https://ci.chromium.org/ui/p/chromium/builders/build/mac-build-perf-ninja/1564/overview https://ci.chromium.org/ui/p/chromium/builders/build/mac-build-perf-developer/1010/overview Original change's description: > DEPS: update ninja to 1.12.1 > > Release notes > https://github.com/ninja-build/ninja/releases/tag/v1.12.0 > https://github.com/ninja-build/ninja/releases/tag/v1.12.1 > > 1.12.1 is 3% faster than 1.11.1 on my linux workstation. > ``` > $ hyperfine --warmup 1 './third_party/ninja/ninja -C out/non_component build:buildflag_header_h' './third_party/ninja/ninja1.12.1 -C out/non_component build:buildflag_header_h' > Benchmark 1: ./third_party/ninja/ninja -C out/non_component build:buildflag_header_h > Time (mean ± σ): 5.672 s ± 0.026 s [User: 5.037 s, System: 0.634 s] > Range (min … max): 5.627 s … 5.709 s 10 runs > > Benchmark 2: ./third_party/ninja/ninja1.12.1 -C out/non_component build:buildflag_header_h > Time (mean ± σ): 5.489 s ± 0.026 s [User: 4.853 s, System: 0.636 s] > Range (min … max): 5.464 s … 5.541 s 10 runs > > Summary > ./third_party/ninja/ninja1.12.1 -C out/non_component build:buildflag_header_h ran > 1.03 ± 0.01 times faster than ./third_party/ninja/ninja -C out/non_component build:buildflag_header_h > ``` > > Bug: 346910589 > Change-Id: I077cbcc4c2cde8df0bac42127a49b4ed4828a1eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5632535 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1315625} Bug: 346910589 Change-Id: I4c10d69b0290427363eb0a14543f034cff90b117 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5635952 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1315646}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.