commit | 1145f5dc7de1bc2d93bbd966e904b36eabe02cdb | [log] [tgz] |
---|---|---|
author | Peter Wen <wnwen@chromium.org> | Tue Oct 04 17:59:29 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 04 17:59:29 2022 |
tree | 78381396b193a65f1a47cd0397e82e8b3c8be388 | |
parent | 2fafc4a9b7fe0b8f48c2e6a2c5803d4510b5c3f6 [diff] |
Revert "Android: Fix crashpad settings not initialized" This reverts commit a64073c1c44b9c9bf38a7027fcdab04b803ea2ff. Reason for revert: See if this CL is the cause of https://crbug.com/1366186 Original change's description: > Android: Fix crashpad settings not initialized > > On some smoke tests, crashpad hits a codepath, perhaps a race condition, > that results in crashpad::Settings::SetUploadsEnabled to be called > before crashpad::Settings::Initialize has been called. This causes the > DCHECK in SetUploadsEnabled to fail and debug builds to fail. > > This CL avoids this codepath in Android, since it is not used. On > Android crashpad doesn't handle uploads. Android uses > //components/minidump_uploader which queries metrics sample/consent opt > in from preferences. > > Bug: 1335513, 1358027 > Fixed: 1358027 > Change-Id: I2718fec4a60eed5adc68aa25a92c737b7b460630 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3872168 > Reviewed-by: Joshua Peraza <jperaza@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1045959} Bug: 1335513, 1358027 Change-Id: I3b97d199ee9f67492149ab09fbd7fbff3a326465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3934513 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1054820}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.