Google Git
Sign in
chromium / chromium / src / 118.0.5993.70
commite52f33f30b91b4ddfad649acddc39ab570473b86[log] [tgz]
authorDi Zhang <dizhangg@chromium.org>Mon Oct 09 18:54:48 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Oct 09 18:54:48 2023
tree180a9f3759329bcaee767a01dcd05b360683a81b
parentd915a853e11ae0ea271ac543846c561cdeac9385 [diff]
[M118] Fix crash in DateTimeFieldElement::DefaultKeyboardEventHandler

In DateTimeFieldElement::DefaultKeyboardEventHandler, we will get a
crash if GetComputedStyle() is called, but returns null. This could
happen for an element where the style does not need to be displayed.
To fix that, we should use the function EnsureComputedStyle() instead.

(cherry picked from commit b227311de4f90092e0527f5f4624c44717854175)

Change-Id: Icb1700f904fcbc0f4cbea78fbdb824b42f7d8149
Bug: 1489714
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4917073
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1206408}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4923273
Reviewed-by: Daniel Yip <danielyip@google.com>
Owners-Override: Daniel Yip <danielyip@google.com>
Cr-Commit-Position: refs/branch-heads/5993@{#1216}
Cr-Branched-From: 511350718e646be62331ae9d7213d10ec320d514-refs/heads/main@{#1192594}
3 files changed
tree: 180a9f3759329bcaee767a01dcd05b360683a81b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. weblayer/
  52. clank
  53. internal
  54. ios_internal
  55. native_client
  56. signing_keys
  57. v8
  58. .clang-format
  59. .clang-tidy
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.