Update FieldDataManager earlier about text-changes

On text field changes the following occurs:
1) Autofill receives a notification about the change.
2) Autofill informs FormTracker about the change.
3) FormTracker receives the signal, does some async posting and
   ultimately updates submission data (which includes a form
   extraction A).
4) FormTracker sends the signal back to AutofillAgent.
5) AutofillAgent updates the FieldDataManager with the given change.
6) AutofillAgent informs PasswordAutofillAgent of the change.
7) PasswordAutofillAgent processes this (which includes a form
   extraction B) and informs the browser about this.

Step 5 updates the data required to compute
FormFieldData::properties_mask_ and FormFieldData::user_input_, which
means that extraction A that happened in Step 3 contained wrong
information, whereas the one that happened in B didn't.

This becomes problematic with the AutofillOptimizeFormExtraction
experiment because we want to extract once and reuse everywhere. This
CL therefore moves the current Step 5 to start happening in between
current Steps 1 and 2.

Bug: 40947729
Change-Id: Ibe846006bc496e28c1043a2ef27c169b287de65b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6170228
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Reviewed-by: Maria Kazinova <kazinova@google.com>
Commit-Queue: Jihad Hanna <jihadghanna@google.com>
Cr-Commit-Position: refs/heads/main@{#1407882}
1 file changed
tree: b06b8454ba69ff9bb0924a1b01deee22cacef7d2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.