commit 11a3a87309e68a4860ac65fbd961e924021ea864
author Gang Wu <gangwu@chromium.org> Wed Nov 25 18:02:01 2020
committer Commit Bot <commit-bot@chromium.org> Wed Nov 25 18:02:01 2020
tree 55e22f55c545029e2b9c2a1ca44c38ad749b5189
parent e09bdc2778fc59f52abdcaf7a6d865205b61b95d

Revert "feed: Don't spin the spinner when its ancestors are hidden"

This reverts commit 46c618aa01355f4bb1a227dc5aae1dcdc790528e.

Reason for revert: crbug.com/1152817

Original change's description:
> feed: Don't spin the spinner when its ancestors are hidden
>
> Currently, the spinner used in feed will only stop() its animation if
> the spinner view itself is hidden through setVisibility(). However, in
> reality, one of its ancestor views is hidden instead.
>
> This causes a continuous invisible animation to tick at the display's
> refresh rate (usually 60fps) if the spinner was ever shown, until it is
> destroyed (when the NTP views are eventually evicted).
>
> Instead, stop the animation also when any of the spinner's ancestors
> become hidden by listening for visibility changes and window attachment
> state changes.
>
> Bug: 1151391
> Change-Id: Ib7b7a8e56f083619420fd58f4340991253402535
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552781
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Jian Li <jianli@chromium.org>
> Commit-Queue: Eric Seckler <eseckler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#830957}

TBR=dewittj@chromium.org,jianli@chromium.org,skyostil@chromium.org,eseckler@chromium.org

Change-Id: Iac8698c1bd7cf2eb5101e7a85811ab15ff929f5f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1151391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560825
Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831060}